Message-ID: <CANiq72kAfcdj+dVaBHsCzTvxp2jdeSiPuv+CJDxoRhy2zpK5xg@mail.gmail.com>
Date:   Sat, 9 Feb 2019 00:32:27 +0100
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Jessica Yu <jeyu@...nel.org>
Cc:     Laura Abbott <labbott@...hat.com>,
        Martin Sebor <msebor@....gnu.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] include/linux/module.h: mark init/cleanup_module
 aliases as __init/exit

On Thu, Feb 7, 2019 at 11:54 AM Jessica Yu <jeyu@...nel.org> wrote:
>
> My order of preference would be 2, 1, striving for 3 eventually.

For reference, for 3), we would need to tweak the following ~130
modules [1]. Quite a lot of them are the simple kind. Also, if we end
up with 3), we could potentially remove a few modpost checks (e.g.
ANY_INIT_TO_ANY_EXIT).

I am submitting the patch for 2). It requires introducing the new
attribute, so let's see if people like it.

Cheers,
Miguel

[1]

arch/x86/kvm/vmx/vmx.c
crypto/async_tx/raid6test.c
crypto/ecdh.c
drivers/block/drbd/drbd_main.c
drivers/bluetooth/btrsi.c
drivers/char/ipmi/ipmi_si_intf.c
drivers/char/ipmi/ipmi_ssif.c
drivers/char/lp.c
drivers/char/mwave/mwavedd.c
drivers/connector/connector.c
drivers/cpufreq/powernow-k8.c
drivers/crypto/ccp/ccp-crypto-main.c
drivers/dma/ti/edma.c
drivers/dma/ti/omap-dma.c
drivers/firmware/efi/efivars.c
drivers/firmware/google/memconsole-coreboot.c
drivers/fmc/fmc-chardev.c
drivers/fmc/fmc-core.c
drivers/fmc/fmc-fakedev.c
drivers/fmc/fmc-trivial.c
drivers/fmc/fmc-write-eeprom.c
drivers/fsi/fsi-core.c
drivers/fsi/fsi-occ.c
drivers/fsi/fsi-sbefifo.c
drivers/fsi/fsi-scom.c
drivers/gpu/drm/drm_drv.c
drivers/hv/hv_util.c
drivers/hwtracing/stm/console.c
drivers/hwtracing/stm/dummy_stm.c
drivers/hwtracing/stm/heartbeat.c
drivers/hwtracing/stm/p_basic.c
drivers/hwtracing/stm/p_sys-t.c
drivers/infiniband/sw/rdmavt/vt.c
drivers/infiniband/ulp/opa_vnic/opa_vnic_vema.c
drivers/isdn/mISDN/core.c
drivers/isdn/mISDN/l1oip_core.c
drivers/lightnvm/pblk-init.c
drivers/mcb/mcb-core.c
drivers/md/bcache/super.c
drivers/md/dm-integrity.c
drivers/md/dm-thin.c
drivers/md/md-cluster.c
drivers/md/md-faulty.c
drivers/md/md-linear.c
drivers/md/raid0.c
drivers/md/raid1.c
drivers/md/raid10.c
drivers/md/raid5.c
drivers/media/common/b2c2/flexcop.c
drivers/media/pci/cx25821/cx25821-alsa.c
drivers/media/pci/ivtv/ivtvfb.c
drivers/media/pci/saa7134/saa7134-alsa.c
drivers/media/platform/davinci/vpif.c
drivers/media/platform/davinci/vpss.c
drivers/media/platform/exynos4-is/fimc-is.c
drivers/media/platform/omap/omap_vout.c
drivers/message/fusion/mptctl.c
drivers/mtd/devices/block2mtd.c
drivers/mtd/maps/sbc_gxx.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
drivers/net/ethernet/microchip/encx24j600.c
drivers/net/fddi/defxx.c
drivers/net/ipvlan/ipvtap.c
drivers/net/macvtap.c
drivers/net/phy/sfp.c
drivers/net/tun.c
drivers/net/vmxnet3/vmxnet3_drv.c
drivers/net/wireless/marvell/mwifiex/main.c
drivers/net/wireless/rsi/rsi_91x_main.c
drivers/net/wireless/rsi/rsi_91x_sdio.c
drivers/nfc/nfcmrvl/uart.c
drivers/pcmcia/i82092.c
drivers/platform/x86/classmate-laptop.c
drivers/platform/x86/thinkpad_acpi.c
drivers/rpmsg/rpmsg_char.c
drivers/scsi/aic7xxx/aic7xxx_osm.c
drivers/scsi/arcmsr/arcmsr_hba.c
drivers/soc/fsl/dpio/dpio-driver.c
drivers/staging/gasket/apex_driver.c
drivers/staging/greybus/fw-core.c
drivers/staging/greybus/loopback.c
drivers/staging/greybus/raw.c
drivers/staging/greybus/uart.c
drivers/staging/unisys/visorhba/visorhba_main.c
drivers/staging/unisys/visornic/visornic_main.c
drivers/tty/rocket.c
drivers/tty/serial/kgdboc.c
drivers/tty/serial/owl-uart.c
drivers/usb/gadget/function/f_tcm.c
drivers/usb/gadget/function/u_serial.c
drivers/vhost/net.c
drivers/vhost/scsi.c
drivers/video/fbdev/aty/aty128fb.c
drivers/video/fbdev/geode/gx1fb_core.c
drivers/video/fbdev/gxt4500.c
drivers/video/fbdev/matrox/matroxfb_crtc2.c
drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
drivers/video/fbdev/nvidia/nvidia.c
drivers/video/fbdev/riva/fbdev.c
drivers/video/fbdev/sstfb.c
drivers/video/fbdev/uvesafb.c
drivers/virtio/virtio.c
drivers/watchdog/cpu5wdt.c
kernel/backtracetest.c
kernel/locking/locktorture.c
kernel/rcu/rcuperf.c
kernel/rcu/rcutorture.c
lib/interval_tree_test.c
lib/memory-notifier-error-inject.c
lib/netdev-notifier-error-inject.c
lib/of-reconfig-notifier-error-inject.c
lib/pm-notifier-error-inject.c
lib/raid6/algos.c
lib/test_ida.c
lib/test_xarray.c
mm/hwpoison-inject.c
net/9p/trans_xen.c
net/core/drop_monitor.c
net/l2tp/l2tp_netlink.c
net/netfilter/xt_NETMAP.c
net/openvswitch/datapath.c
net/rds/af_rds.c
net/rds/rdma_transport.c
net/rds/tcp.c
samples/connector/cn_test.c
samples/livepatch/livepatch-callbacks-busymod.c
samples/livepatch/livepatch-callbacks-demo.c
samples/livepatch/livepatch-callbacks-mod.c
samples/livepatch/livepatch-sample.c
samples/livepatch/livepatch-shadow-fix1.c
samples/livepatch/livepatch-shadow-fix2.c
samples/livepatch/livepatch-shadow-mod.c

Powered by blists - more mailing lists