linux-kernel - Re: [PATCH v2] lib/scatterlist: Provide a DMA page iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97c4d30915593e8a81cb6cd5f44dc09c9fc1343c.camel@vmware.com>
Date:   Fri, 8 Feb 2019 07:44:36 +0000
From:   Thomas Hellstrom <thellstrom@...are.com>
To:     "yong.zhi@...el.com" <yong.zhi@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "daniel.vetter@...ll.ch" <daniel.vetter@...ll.ch>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "Christian.Koenig@....com" <Christian.Koenig@....com>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "jgg@...lanox.com" <jgg@...lanox.com>, "hch@....de" <hch@....de>,
        "tian.shu.qiu@...el.com" <tian.shu.qiu@...el.com>,
        "bingbu.cao@...el.com" <bingbu.cao@...el.com>,
        "daniel@...ishbar.org" <daniel@...ishbar.org>,
        "shiraz.saleem@...el.com" <shiraz.saleem@...el.com>,
        "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH v2] lib/scatterlist: Provide a DMA page iterator

On Thu, 2019-02-07 at 22:26 +0000, Jason Gunthorpe wrote:
> Commit 2db76d7c3c6d ("lib/scatterlist: sg_page_iter: support sg lists
> w/o
> backing pages") introduced the sg_page_iter_dma_address() function
> without
> providing a way to use it in the general case. If the sg_dma_len() is
> not
> equal to the sg length callers cannot safely use the
> for_each_sg_page/sg_page_iter_dma_address combination.
> 
> Resolve this API mistake by providing a DMA specific iterator,
> for_each_sg_dma_page(), that uses the right length so
> sg_page_iter_dma_address() works as expected with all sglists.
> 
> A new iterator type is introduced to provide compile-time safety
> against
> wrongly mixing accessors and iterators.
> 
> Acked-by: Christoph Hellwig <hch@....de> (for scatterlist)
> Signed-off-by: Jason Gunthorpe <jgg@...lanox.com>
> 

For the vmwgfx part, 
Acked-by: Thomas Hellstrom <thellstrom@...are.com>

I'll take a deeper look to provide a vmwgfx fix as a follow up.

Thanks,
Thomas