linux-kernel - Re: [BUGFIX PATCH] crypto: ccree: fix resume race condition on init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190208074825.d24swebf2cz3edrk@gondor.apana.org.au>
Date:   Fri, 8 Feb 2019 15:48:25 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Gilad Ben-Yossef <gilad@...yossef.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Ofir Drag <ofir.drang@....com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        stable@...nel.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [BUGFIX PATCH] crypto: ccree: fix resume race condition on init

On Thu, Feb 07, 2019 at 03:36:11PM +0200, Gilad Ben-Yossef wrote:
> We were enabling autosuspend, which is using data set by the
> hash module, prior to the hash module being inited, casuing
> a crash on resume as part of the startup sequence if the race
> was lost.
> 
> This was never a real problem because the PM infra was using low
> res timers so we were always winning the race, until commit 8234f6734c5d
> ("PM-runtime: Switch autosuspend over to using hrtimers") changed that :-)
> 
> Fix this by seperating the PM setup and enablement and doing the
> latter only at the end of the init sequence.
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@...yossef.com>
> Cc: Vincent Guittot <vincent.guittot@...aro.org>
> Cc: stable@...nel.org # v4.20
> ---
> Herbert, could you please take this for 5.0-rc6 ? thanks.
> 
>  drivers/crypto/ccree/cc_driver.c |  7 ++++---
>  drivers/crypto/ccree/cc_pm.c     | 13 ++++++-------
>  drivers/crypto/ccree/cc_pm.h     |  3 +++
>  3 files changed, 13 insertions(+), 10 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt