linux-kernel - Re: [PATCH] HISI LPC: Don't fail probe for unrecognised child devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <249f851b-e28c-c5df-7706-f7212162bae7@hisilicon.com>
Date:   Fri, 8 Feb 2019 09:49:16 +0000
From:   Wei Xu <xuwei5@...ilicon.com>
To:     John Garry <john.garry@...wei.com>, <xuwei5@...wei.com>
CC:     <arm@...nel.org>, <linuxarm@...wei.com>,
        <linux-kernel@...r.kernel.org>, <olof@...om.net>
Subject: Re: [PATCH] HISI LPC: Don't fail probe for unrecognised child devices

Hi John,

On 1/3/2019 11:57 AM, John Garry wrote:
> Currently for ACPI-based FW we fail the probe for an unrecognised child
> HID.
> 
> However, there is FW in the field with LPC child devices having fake HIDs,
> namely "IPI0002", which was an IPMI device invented to support the
> initial out-of-tree LPC host driver, different from the final mainline
> version.
> 
> To provide compatibility support for these dodgy FWs, just discard the
> unrecognised HIDs instead of failing the probe altogether.
> 
> Tested-by: Zengruan Ye <yezengruan@...wei.com>
> Signed-off-by: John Garry <john.garry@...wei.com>

Updated the subject as "bus: hisi_lpc: xxx" to follow the style and
applied to the hisilicon tree.
Thanks!

Best Regards,
Wei

> 
> diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
> index d5f8545..19d7b6f 100644
> --- a/drivers/bus/hisi_lpc.c
> +++ b/drivers/bus/hisi_lpc.c
> @@ -522,10 +522,9 @@ static int hisi_lpc_acpi_probe(struct device *hostdev)
>  
>  		if (!found) {
>  			dev_warn(hostdev,
> -				 "could not find cell for child device (%s)\n",
> +				 "could not find cell for child device (%s), discarding\n",
>  				 hid);
> -			ret = -ENODEV;
> -			goto fail;
> +			continue;
>  		}
>  
>  		pdev = platform_device_alloc(cell->name, PLATFORM_DEVID_AUTO);
>