linux-kernel - Re: [PATCH v3 14/15] habanalabs: add debugfs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190208121603.GC23483@kroah.com>
Date:   Fri, 8 Feb 2019 13:16:03 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Oded Gabbay <oded.gabbay@...il.com>
Cc:     linux-kernel@...r.kernel.org, olof@...om.net, rppt@...ux.ibm.com,
        ogabbay@...ana.ai, arnd@...db.de, joe@...ches.com
Subject: Re: [PATCH v3 14/15] habanalabs: add debugfs support

On Mon, Feb 04, 2019 at 10:32:53PM +0200, Oded Gabbay wrote:
> +int __init hl_debugfs_init(void)
> +{
> +	hl_debug_root = debugfs_create_dir("habanalabs", NULL);
> +	if (IS_ERR_OR_NULL(hl_debug_root)) {
> +		pr_err("can not create debugfs directory\n");
> +		hl_debug_root = NULL;
> +		return -ENOMEM;
> +	}
> +
> +	return 0;
> +}

This function should just be one line:
void __init hl_debugfs_init(void)
{
	hl_debug_root = debugfs_create_dir("habanalabs", NULL);
}

No need to do anything else, or check anything.

thanks,

greg k-h