linux-kernel - Re: [PATCH v2 1/2] drm/omap: panel-tpo-td028ttec1: add backlight support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190208010542.GI10386@pendragon.ideasonboard.com>
Date:   Fri, 8 Feb 2019 03:05:42 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Andreas Kemnade <andreas@...nade.info>
Cc:     tomi.valkeinen@...com, airlied@...ux.ie, daniel@...ll.ch,
        sre@...nel.org, dri-devel@...ts.freedesktop.org,
        robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        letux-kernel@...nphoenux.org
Subject: Re: [PATCH v2 1/2] drm/omap: panel-tpo-td028ttec1: add backlight
 support

Hi Andreas,

Thank you for the patch.

On Tue, Feb 05, 2019 at 07:38:12AM +0100, Andreas Kemnade wrote:
> This panel has a backlight, so fetch it from devicetree using the
> corresponding property as documented in panel-common.txt. It is
> implemented the same way as in panel-dpi.c
> This ensures the backlight is also disabled when the display is
> turned off like when doing xset dpms force off.
> 
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
> Changes in v2: 
>  - do not reorder initialisation
>  - fix commit message
> 
>  drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
> index 7ddc8c574a61..1db8740f3c21 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
> @@ -35,6 +35,8 @@ struct panel_drv_data {
>  
>  	struct videomode vm;
>  
> +	struct backlight_device *backlight;
> +
>  	struct spi_device *spi_dev;
>  };
>  
> @@ -268,6 +270,8 @@ static int td028ttec1_panel_enable(struct omap_dss_device *dssdev)
>  
>  	r |= jbt_ret_write_0(ddata, JBT_REG_DISPLAY_ON);
>  
> +	backlight_enable(ddata->backlight);
> +
>  	dssdev->state = OMAP_DSS_DISPLAY_ACTIVE;
>  
>  transfer_err:
> @@ -283,6 +287,8 @@ static void td028ttec1_panel_disable(struct omap_dss_device *dssdev)
>  	if (!omapdss_device_is_enabled(dssdev))
>  		return;
>  
> +	backlight_disable(ddata->backlight);
> +
>  	dev_dbg(dssdev->dev, "td028ttec1_panel_disable()\n");
>  
>  	jbt_ret_write_0(ddata, JBT_REG_DISPLAY_OFF);
> @@ -334,6 +340,10 @@ static int td028ttec1_panel_probe(struct spi_device *spi)
>  	if (ddata == NULL)
>  		return -ENOMEM;
>  
> +	ddata->backlight = devm_of_find_backlight(&spi->dev);
> +	if (IS_ERR(ddata->backlight))
> +		return PTR_ERR(ddata->backlight);
> +
>  	dev_set_drvdata(&spi->dev, ddata);
>  
>  	ddata->spi_dev = spi;

-- 
Regards,

Laurent Pinchart