linux-kernel - Re: [PATCH 2/2] drivers/gpio/gpio-adp5588.c: switch to events system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYUCyL6ZE=OgWQd5ps-1s8-Xzm8P-NMfiVCviOm3s3sAg@mail.gmail.com>
Date:   Fri, 8 Feb 2019 14:43:00 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Nikolaus Voss <nv@...n.de>
Cc:     Michael Hennerich <michael.hennerich@...log.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Nikolaus Voss <nikolaus.voss@...wensteinmedical.de>
Subject: Re: [PATCH 2/2] drivers/gpio/gpio-adp5588.c: switch to events system

On Tue, Feb 5, 2019 at 4:17 PM Nikolaus Voss <nv@...n.de> wrote:

> Interupts were generated using GPIN interrupts of
> ADP5588. These interrupts have two important limitations:
> 1. Interrupts can only be generated for either rising or
>    falling edges but not both.
> 2. Interrupts are reasserted as long as the interrupt condition
>    persists (i.e. high or low level on that GPIN). This generates
>    lots of interrupts unless the event is very short.
>
> To overcome this, ADP5588 provides an event system which queues
> up to 10 events in a buffer. GPIN events are queued whenever the
> GPIN is asserted or deasserted. This makes it possible to support
> generating GPIN interrupts for both edges and to generate only one
> interrupt per state change.
> Thus it is possible to chain the gpio-keys driver for some GPIOs.
>
> Signed-off-by: Nikolaus Voss <nikolaus.voss@...wensteinmedical.de>

Patch applied with Michael's ACK.

Yours,
Linus Walleij