[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190208140834.GA25255@linux.intel.com>
Date: Fri, 8 Feb 2019 16:08:34 +0200
From: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To: Stefan Berger <stefanb@...ux.ibm.com>
Cc: Alexander Steffen <Alexander.Steffen@...ineon.com>,
linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-security-module@...r.kernel.org,
Peter Huewe <PeterHuewe@....de>,
Jason Gunthorpe <jgg@...pe.ca>,
Tomas Winkler <tomas.winkler@...el.com>,
Tadeusz Struk <tadeusz.struk@...el.com>,
Stefan Berger <stefanb@...ux.vnet.ibm.com>,
Nayna Jain <nayna@...ux.ibm.com>
Subject: Re: [PATCH v11 00/16] Remove nested TPM operations
On Fri, Feb 08, 2019 at 09:02:22AM -0500, Stefan Berger wrote:
> On 2/8/19 8:33 AM, Jarkko Sakkinen wrote:
> >
> > if (len != be32_to_cpu(header->length)) {
> > rc = -EFAULT;
> > goto out;
> > }
> >
> > rc = tpm2_commit_space(chip, space, ordinal, buf, &len);
> > if (rc)
> > dev_err(&chip->dev, "tpm2_commit_space: error %d\n", rc);
> >
> > That unconditional call to commit space masked the bugs in the device
> > drivers. I'll provide fixes shortly.
>
> You got it! :-)
Yes, and it should not be fixes in tpm-interface.c. Sent a patch set
for review.
Thanks for spotting this out!
/Jarkko
Powered by blists - more mailing lists