linux-kernel - Re: [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Feb 2019 14:43:22 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <beanhuo@...ron.com>, <linux-mtd@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
CC:     <marek.vasut@...il.com>, <dwmw2@...radead.org>,
        <computersforpeace@...il.com>, <bbrezillon@...nel.org>,
        <richard@....at>
Subject: Re: [PATCH v2] mtd: spi-nor: Fix wrong abbreviation HWCPAS


On 02/08/2019 04:23 PM, Bean Huo (beanhuo) wrote:
> Change SNOR_HWCPAS_READ_OCTAL to SNOR_HWCAPS_READ_OCTAL.
> 
> Signed-off-by: Bean Huo <beanhuo@...ron.com>

$ ./scripts/checkpatch.pl --strict
v2-mtd-spi-nor-Fix-wrong-abbreviation-HWCPAS.patch
WARNING: Missing Signed-off-by: line by nominal patch author 'Bean Huo (beanhuo)
<beanhuo@...ron.com>'

There are scripts that check that the author/committer has its SoB, depending on
how strict the check is, it might complaint that SoB an author/committer do not
match, so please change gitconfig to make them match.

> ---
>  include/linux/mtd/spi-nor.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h
> index 2353af8..b3d360b 100644
> --- a/include/linux/mtd/spi-nor.h
> +++ b/include/linux/mtd/spi-nor.h
> @@ -487,7 +487,7 @@ struct spi_nor_hwcaps {
>  #define SNOR_HWCAPS_READ_4_4_4		BIT(9)
>  #define SNOR_HWCAPS_READ_1_4_4_DTR	BIT(10)
>  
> -#define SNOR_HWCPAS_READ_OCTAL		GENMASK(14, 11)
> +#define SNOR_HWCAPS_READ_OCTAL		GENMASK(14, 11)
>  #define SNOR_HWCAPS_READ_1_1_8		BIT(11)
>  #define SNOR_HWCAPS_READ_1_8_8		BIT(12)
>  #define SNOR_HWCAPS_READ_8_8_8		BIT(13)
>