linux-kernel - Re: [PATCH v2 0/2] tpm: Unify send() callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <b0469b08-18fd-847b-0f0b-6223c732b346@linux.ibm.com>
Date:   Fri, 8 Feb 2019 11:14:42 -0500
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        linux-integrity@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        Peter Huewe <PeterHuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        Alexander Steffen <Alexander.Steffen@...ineon.com>
Subject: Re: [PATCH v2 0/2] tpm: Unify send() callbacks

On 2/8/19 11:03 AM, Jarkko Sakkinen wrote:
> A portion of send() callbacks have returned length, in many cases just
> returning back what was given as an argument, and tpm_crb has returned 0 on
> success. This patch set fixes and unifies the behaviour.
>
> v2:
> The drivers tpm_nsc and tpm_infineon were forgotten. For this version I
> checked both with find and command and from Kconfig that everything that is
> supposed to be a driver directly interfacing with the TPM core, is included
> (e.g. discluding tpm_tis_spi).


:-( st33zp24/i2c.c ends up calling i2c_master_send, which returns number 
of bytes written:

https://elixir.bootlin.com/linux/latest/source/include/linux/i2c.h#L108


>
> Jarkko Sakkinen (2):
>    tpm: Unify the send callback behaviour
>    tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete
>
>   drivers/char/tpm/st33zp24/st33zp24.c |  2 +-
>   drivers/char/tpm/tpm_atmel.c         |  2 +-
>   drivers/char/tpm/tpm_i2c_atmel.c     | 10 +++++++++-
>   drivers/char/tpm/tpm_i2c_infineon.c  |  2 +-
>   drivers/char/tpm/tpm_i2c_nuvoton.c   |  2 +-
>   drivers/char/tpm/tpm_ibmvtpm.c       |  2 +-
>   drivers/char/tpm/tpm_infineon.c      |  2 +-
>   drivers/char/tpm/tpm_nsc.c           |  2 +-
>   drivers/char/tpm/tpm_vtpm_proxy.c    |  3 +--
>   drivers/char/tpm/xen-tpmfront.c      |  2 +-
>   10 files changed, 18 insertions(+), 11 deletions(-)
>