lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 8 Feb 2019 11:19:04 -0500
From:   Stefan Berger <>
To:     Jarkko Sakkinen <>
        Peter Huewe <>,
        Jason Gunthorpe <>,
        Stefan Berger <>,
        Nayna Jain <>,
Subject: Re: [PATCH 1/2] tpm: Unify the send callback behaviour

On 2/8/19 11:07 AM, Jarkko Sakkinen wrote:
> On Fri, Feb 08, 2019 at 10:45:53AM -0500, Stefan Berger wrote:
>> On 2/8/19 10:42 AM, Jarkko Sakkinen wrote:
>>> On Fri, Feb 08, 2019 at 09:42:16AM -0500, Stefan Berger wrote: > On 2/8/19 9:05 AM, Jarkko Sakkinen wrote:
>>>> At least tpm_nsc_send (tpm_nsc.c) and tpm_inf_send (tpm_infineon.c) are also
>>>> returning the number of bytes sent. I would consider tpm_crb the outlier
>>>> that returns 0 and should return the length even though we don't need it...
>>> That would be absolutely wrong way the fix the *actual* issue i.e.
>>> callbacks returning garbage (sometimes just passing the length parameter
>>> back as a return value).
>> Then I guess you have to fixes those other two files as well...
> That's still a better option.

tpm_tis_core.c's tpm_tis_send_main() also needs fixing...

> /Jarkko

Powered by blists - more mailing lists