linux-kernel - Re: [PATCH v3 2/5] i2c:ocores: do not handle IRQ if IF is not set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190208170003.GB1853@lunn.ch>
Date:   Fri, 8 Feb 2019 18:00:03 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Federico Vaga <federico.vaga@...n.ch>
Cc:     Peter Korsgaard <peter@...sgaard.com>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/5] i2c:ocores: do not handle IRQ if IF is not set

On Fri, Feb 08, 2019 at 05:11:58PM +0100, Federico Vaga wrote:
> If the Interrupt Flag (IF) is not set, we should not handle the IRQ:
> - the line can be shared with other devices
> - it can be a spurious interrupt
> 
> To avoid reading twice the status register, the ocores_process() function
> expects it to be read by the caller.
> 
> Signed-off-by: Federico Vaga <federico.vaga@...n.ch>
> Acked-by: Peter Korsgaard <peter@...sgaard.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew