linux-kernel - Re: [PATCH v2] mm: proc: smaps_rollup: Fix pss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b8e236d-7c43-6c2b-cb3f-cbb0b8923fe2@suse.cz>
Date:   Fri, 8 Feb 2019 18:04:24 +0100
From:   Vlastimil Babka <vbabka@...e.cz>
To:     Sandeep Patil <sspatil@...roid.com>, adobriyan@...il.com,
        akpm@...ux-foundation.org, avagin@...nvz.org
Cc:     linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        kernel-team@...roid.com, dancol@...gle.com
Subject: Re: [PATCH v2] mm: proc: smaps_rollup: Fix pss_locked calculation

On 2/3/19 7:54 AM, Sandeep Patil wrote:
> The 'pss_locked' field of smaps_rollup was being calculated incorrectly.
> It accumulated the current pss everytime a locked VMA was found.  Fix
> that by adding to 'pss_locked' the same time as that of 'pss' if the vma
> being walked is locked.
> 
> Fixes: 493b0e9d945f ("mm: add /proc/pid/smaps_rollup")
> Cc: stable@...r.kernel.org # 4.14.y 4.19.y
> Signed-off-by: Sandeep Patil <sspatil@...roid.com>

Acked-by: Vlastimil Babka <vbabka@...e.cz>

Thanks.

> ---
> 
> v1->v2
> ------
> - Move pss_locked accounting into smaps_account() inline with pss