linux-kernel - Re: [PATCH v3 4/5] i2c:ocores: add SPDX tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <789738e8-609a-f20b-11c2-54089366f612@axentia.se>
Date:   Fri, 8 Feb 2019 17:16:59 +0000
From:   Peter Rosin <peda@...ntia.se>
To:     Federico Vaga <federico.vaga@...n.ch>,
        Peter Korsgaard <peter@...sgaard.com>,
        Andrew Lunn <andrew@...n.ch>
CC:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 4/5] i2c:ocores: add SPDX tag

On 2019-02-08 17:12, Federico Vaga wrote:
> It adds the SPDX tag and it removes the old text about the GPLv2.
> 
> Signed-off-by: Federico Vaga <federico.vaga@...n.ch>
> ---
>  drivers/i2c/busses/i2c-ocores.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
> index bbe3e96..5b80190 100644
> --- a/drivers/i2c/busses/i2c-ocores.c
> +++ b/drivers/i2c/busses/i2c-ocores.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
>  /*
>   * i2c-ocores.c: I2C bus driver for OpenCores I2C controller
>   * (https://opencores.org/project/i2c/overview)
> @@ -7,9 +8,8 @@
>   * Support for the GRLIB port of the controller by
>   * Andreas Larsson <andreas@...sler.com>
>   *
> - * This file is licensed under the terms of the GNU General Public License
> - * version 2.  This program is licensed "as is" without any warranty of any
> - * kind, whether express or implied.
> + * This program is licensed "as is" without any warranty of any kind,
> + * whether express or implied.
>   */
>  
>  #include <linux/clk.h>
> 

If you feel that you need to keep some license boilerplate after adding
the SPDX tag, then the SPDX tag is per default wrong. The SPDX tag should be
a full description of the applicable license. What's the point otherwise?
In this case though, GPLv2 already contains this gist of the boilerplate
text (in section 11) so please just kill the whole paragraph.

Cheers,
Peter