lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 8 Feb 2019 19:27:17 +0200
From:   Andy Shevchenko <>
To:     Petr Mladek <>
Cc:     Rasmus Villemoes <>,
        Linus Torvalds <>,
        "Tobin C . Harding" <>, Joe Perches <>,
        Andrew Morton <>,
        Michal Hocko <>,
        Sergey Senozhatsky <>,
        Steven Rostedt <>,
        Sergey Senozhatsky <>,
Subject: Re: [PATCH v6 9/9] vsprintf: Avoid confusion between invalid address
 and value

On Fri, Feb 08, 2019 at 04:23:10PM +0100, Petr Mladek wrote:
> We are able to detect invalid values handled by %p[iI] printk specifier.
> The current error message is "invalid address". It might cause confusion
> against "(efault)" reported by the generic valid_pointer_address() check.
> Let's unify the style and use the more appropriate error code description
> "(einval)".

The proper one should be "invalid address family". The proposed change
increases confusion.

With Best Regards,
Andy Shevchenko

Powered by blists - more mailing lists