linux-kernel - Re: [PATCH 0/3] firmware_loader: few selftest fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18f2e46e-8171-58e2-41d0-c4272fb9b00d@kernel.org>
Date:   Fri, 8 Feb 2019 10:57:35 -0700
From:   shuah <shuah@...nel.org>
To:     "Luis R. Rodriguez" <mcgrof@...nel.org>, gregkh@...uxfoundation.org
Cc:     akpm@...ux-foundation.org, josh@...htriplett.org,
        rishabhb@...eaurora.org, kubakici@...pl, maco@...roid.com,
        andy.gross@...aro.org, david.brown@...aro.org,
        bjorn.andersson@...aro.org, linux-wireless@...r.kernel.org,
        keescook@...omium.org, mfuzzey@...keon.com,
        zohar@...ux.vnet.ibm.com, dhowells@...hat.com,
        pali.rohar@...il.com, tiwai@...e.de, arend.vanspriel@...adcom.com,
        zajec5@...il.com, nbroeking@...com, markivx@...eaurora.org,
        broonie@...nel.org, dmitry.torokhov@...il.com, dwmw2@...radead.org,
        torvalds@...ux-foundation.org, Abhay_Salunke@...l.com,
        jewalt@...innovations.com, cantabile.desu@...il.com, ast@...com,
        andresx7@...il.com, dan.rue@...aro.org, brendanhiggins@...gle.com,
        yzaikin@...gle.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, shuah <shuah@...nel.org>
Subject: Re: [PATCH 0/3] firmware_loader: few selftest fixes

On 2/7/19 12:05 PM, Luis R. Rodriguez wrote:
> From: Luis Chamberlain <mcgrof@...nel.org>
> 
> Greg,
> 
> I've found that Dan's patches really broke firmware testing. I've
> identified a proper fix for the issue he found, its the last patch. This
> series reverts his two patches which break testing, and fixes the issue
> he was running into. I leave it to him as exercise to add a busybox bash
> quirk for the bash issue he found with diff.
> 
> His patches are merged on v5.0-rc1 as such these should go to Linus
> tree as well. They are regressions on v5.0-rc1. Please let me know if
> there are any questions.
> 
>    Luis
> 
> Luis Chamberlain (3):
>    Revert "selftests: firmware: add CONFIG_FW_LOADER_USER_HELPER_FALLBACK
>      to config"
>    Revert "selftests: firmware: remove use of non-standard diff -Z
>      option"
>    selftests: firmware: fix verify_reqs() return value
> 
>   tools/testing/selftests/firmware/config           | 1 -
>   tools/testing/selftests/firmware/fw_filesystem.sh | 9 ++++++---
>   tools/testing/selftests/firmware/fw_lib.sh        | 2 +-
>   3 files changed, 7 insertions(+), 5 deletions(-)
> 

Luis: Thanks for finding and fixing the problems. My apologies
for pulling the problem patch in by mistake in the first place. :(

Greg! Do you plan to take these through firmware or do you want
me to get these in through kselftest tree. Either way is fine.

Acked-by: Shuah Khan <shuah@...nel.org>

thanks,
-- Shuah