linux-kernel - Re: [PATCH V17 3/6] i2c: tegra: fix maximum transfer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e4db3e9-8198-f1bf-f909-492bf1ff8c56@gmail.com>
Date:   Fri, 8 Feb 2019 21:21:09 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Sowjanya Komatineni <skomatineni@...dia.com>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Mantravadi Karthik <mkarthik@...dia.com>,
        Shardar Mohammed <smohammed@...dia.com>,
        Timo Alho <talho@...dia.com>
Cc:     "wsa@...-dreams.de" <wsa@...-dreams.de>,
        "peda@...ntia.se" <peda@...ntia.se>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH V17 3/6] i2c: tegra: fix maximum transfer size

08.02.2019 21:17, Sowjanya Komatineni пишет:
> 
>>>  static const struct i2c_adapter_quirks tegra194_i2c_quirks = {
>>>  	.flags = I2C_AQ_NO_ZERO_LEN,
>>> +	.max_write_len = 65535 - I2C_PACKET_HEADER_SIZE,
>>
>> Ideally it should be SZ_64K - I2C_PACKET_HEADER_SIZE to not miss the one byte, otherwise good to me:
>>
>> Reviewed-by: Dmitry Osipenko <digetx@...il.com>
> 
> With SZ_64K - I2C_PACKET_HEADR_Size, When we compute dma_buf_size = max_write_len + I2C_PACKET_HEADER_SIZE, dma_buf_size will be SZ_64K which is 0x10000 apbdma dma count limit should be < 64K meaning 65535 max is allowed
> 

But it's for the GPCDMA, does it have the same 64K limit as APB DMA?