linux-kernel - Re: [PATCH v8 1/6] fieldbus_dev: add Fieldbus Device subsystem.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190209091142.GC3377@kroah.com>
Date:   Sat, 9 Feb 2019 10:11:42 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Sven Van Asbroeck <thesven73@...il.com>
Cc:     Sven Van Asbroeck <svendev@...x.com>, robh+dt@...nel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Lee Jones <lee.jones@...aro.org>, mark.rutland@....com,
        Andreas Färber <afaerber@...e.de>,
        treding@...dia.com, David Lechner <david@...hnology.com>,
        noralf@...nnes.org, johan@...nel.org,
        Michal Simek <monstr@...str.eu>, michal.vokac@...ft.com,
        Arnd Bergmann <arnd@...db.de>, john.garry@...wei.com,
        geert+renesas@...der.be, robin.murphy@....com,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        sebastien.bourdelin@...oirfairelinux.com, icenowy@...c.io,
        Stuart Yoder <stuyoder@...il.com>, maxime.ripard@...tlin.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8 1/6] fieldbus_dev: add Fieldbus Device subsystem.

On Fri, Feb 08, 2019 at 11:30:22AM -0500, Sven Van Asbroeck wrote:
> On Fri, Feb 8, 2019 at 7:18 AM Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > > +static DEFINE_IDA(fieldbus_ida);
> >
> > You forget to destroy this ida structure when the module is removed.
> > It's a common thing to get wrong :(
> >
> 
> But fieldbus_ida is allocated on the heap. So as long as calls to
> ida_simple_get() and ida_simple_remove() are matched, there
> should be no resource leak?
> 
> What am I missing?

the ida structure does some internal allocations and ida_destroy() has
to be called when your code is being removed to properly free it.

Again, it's not obvious at all, but it is needed :(

thanks,

greg k-h