linux-kernel - Re: [PATCH] watchdog/hpwdt: Update Kconfig documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a20685a2-1f30-5088-7ad5-fe4d590e3a37@roeck-us.net>
Date:   Fri, 8 Feb 2019 21:10:51 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jerry Hoemann <jerry.hoemann@....com>, wim@...ux-watchdog.org
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog/hpwdt: Update Kconfig documentation

On 2/8/19 9:48 AM, Jerry Hoemann wrote:
> Update documentation relating to HPWDT_NMI_DECODING to reflect its
> current usage.
> 
> Signed-off-by: Jerry Hoemann <jerry.hoemann@....com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/Kconfig | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 57f017d..846dd07 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1145,7 +1145,7 @@ config HP_WATCHDOG
>   	select WATCHDOG_CORE
>   	depends on X86 && PCI
>   	help
> -	  A software monitoring watchdog and NMI sourcing driver. This driver
> +	  A software monitoring watchdog and NMI handling driver. This driver
>   	  will detect lockups and provide a stack trace. This is a driver that
>   	  will only load on an HP ProLiant system with a minimum of iLO2 support.
>   	  To compile this driver as a module, choose M here: the module will be
> @@ -1163,12 +1163,13 @@ config KEMPLD_WDT
>   	  called kempld_wdt.
>   
>   config HPWDT_NMI_DECODING
> -	bool "NMI decoding support for the HP ProLiant iLO2+ Hardware Watchdog Timer"
> +	bool "NMI support for the HP ProLiant iLO2+ Hardware Watchdog Timer"
>   	depends on HP_WATCHDOG
>   	default y
>   	help
> -	  When an NMI occurs this feature will make the necessary BIOS calls to
> -	  log the cause of the NMI.
> +	  Enables the NMI handler for the watchdog pretimeout NMI and the iLO
> +	  "Generate NMI to System" virtual button.  When an NMI is claimed
> +	  by the driver, panic is called.
>   
>   config SC1200_WDT
>   	tristate "National Semiconductor PC87307/PC97307 (ala SC1200) Watchdog"
>