linux-kernel - [tip:irq/core] softirq: Don't skip softirq execution when softirq thread is parking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-1342d8080f6183b0419a9246c6e6545e21fa1e05@git.kernel.org>
Date:   Sun, 10 Feb 2019 12:57:05 -0800
From:   tip-bot for Matthias Kaehlcke <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     hpa@...or.com, paulmck@...ux.vnet.ibm.com, dianders@...omium.org,
        swboyd@...omium.org, bigeasy@...utronix.de, mingo@...nel.org,
        peterz@...radead.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, mka@...omium.org, rostedt@...dmis.org
Subject: [tip:irq/core] softirq: Don't skip softirq execution when softirq
 thread is parking

Commit-ID:  1342d8080f6183b0419a9246c6e6545e21fa1e05
Gitweb:     https://git.kernel.org/tip/1342d8080f6183b0419a9246c6e6545e21fa1e05
Author:     Matthias Kaehlcke <mka@...omium.org>
AuthorDate: Mon, 28 Jan 2019 15:46:25 -0800
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Sun, 10 Feb 2019 21:51:39 +0100

softirq: Don't skip softirq execution when softirq thread is parking

When a CPU is unplugged the kernel threads of this CPU are parked (see
smpboot_park_threads()). kthread_park() is used to mark each thread as
parked and wake it up, so it can complete the process of parking itselfs
(see smpboot_thread_fn()).

If local softirqs are pending on interrupt exit invoke_softirq() is called
to process the softirqs, however it skips processing when the softirq
kernel thread of the local CPU is scheduled to run. The softirq kthread is
one of the threads that is parked when a CPU is unplugged. Parking the
kthread wakes it up, however only to complete the parking process, not to
process the pending softirqs. Hence processing of softirqs at the end of an
interrupt is skipped, but not done elsewhere, which can result in warnings
about pending softirqs when a CPU is unplugged:

/sys/devices/system/cpu # echo 0 > cpu4/online
[ ... ] NOHZ: local_softirq_pending 02
[ ... ] NOHZ: local_softirq_pending 202
[ ... ] CPU4: shutdown
[ ... ] psci: CPU4 killed.

Don't skip processing of softirqs at the end of an interrupt when the
softirq thread of the CPU is parking.

Signed-off-by: Matthias Kaehlcke <mka@...omium.org>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Steven Rostedt <rostedt@...dmis.org>
Cc: "Paul E . McKenney" <paulmck@...ux.vnet.ibm.com>
Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: Douglas Anderson <dianders@...omium.org>
Cc: Stephen Boyd <swboyd@...omium.org>
Link: https://lkml.kernel.org/r/20190128234625.78241-3-mka@chromium.org

---
 kernel/softirq.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/softirq.c b/kernel/softirq.c
index d28813306b2c..10277429ed84 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -89,7 +89,8 @@ static bool ksoftirqd_running(unsigned long pending)

 	if (pending & SOFTIRQ_NOW_MASK)
 		return false;
-	return tsk && (tsk->state == TASK_RUNNING);
+	return tsk && (tsk->state == TASK_RUNNING) &&
+		!__kthread_should_park(tsk);
 }

 /*