linux-kernel - Re: [PATCH] mm/gup.c: Remove unused write variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190210222902.GA13720@iweiny-DESK2.sc.intel.com>
Date:   Sun, 10 Feb 2019 14:29:03 -0800
From:   Ira Weiny <ira.weiny@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        x86@...nel.org, linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH] mm/gup.c: Remove unused write variable

On Sun, Feb 10, 2019 at 08:39:44PM +0100, Thomas Gleixner wrote:
> Ira,
> 
> On Sat, 9 Feb 2019, ira.weiny@...el.com wrote:
> 
> nice patch. Just a few nitpicks vs. the subject and the change log.
> 
> > Subject: [PATCH] mm/gup.c: Remove unused write variable
> 
> We usually avoid filenames in the subsystem prefix. mm/gup: is sufficient.

Thanks.

> 
> But what's a bit more confusing is 'write variable'. You are not removing a
> variable, you are removing a unused function argument. That's two different
> things.

Indeed my mistake.

> 
> > write is unused in gup_fast_permitted so remove it.
> 
> When referencing functions please use brackets so it's clear that you talk
> about a function, i.e. gup_fast_permitted().
> 
> So the correct subject line would be:
> 
>   Subject: [PATCH] mm/gup: Remove write argument from gup_fast_permitted()

NP, V2 on its way,
Ira

> 
> Thanks,
> 
> 	tglx