linux-kernel - Re: [PATCH] arm64: use memblocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 10 Feb 2019 11:55:15 +0200
From:   Mike Rapoport <rppt@...ux.ibm.com>
To:     Peng Fan <peng.fan@....com>
Cc:     "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "rppt@...ux.vnet.ibm.com" <rppt@...ux.vnet.ibm.com>,
        "ard.biesheuvel@...aro.org" <ard.biesheuvel@...aro.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "james.morse@....com" <james.morse@....com>,
        "ghackmann@...roid.com" <ghackmann@...roid.com>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "hannes@...xchg.org" <hannes@...xchg.org>,
        "logang@...tatee.com" <logang@...tatee.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "van.freenix@...il.com" <van.freenix@...il.com>
Subject: Re: [PATCH] arm64: use memblocks_present

On Sun, Feb 10, 2019 at 09:28:43AM +0000, Peng Fan wrote:
> arm64_memory_present is doing same thing as memblocks_present, so
> let's use common code memblocks_present instead of platform
> specific arm64_memory_present.
> 
> Signed-off-by: Peng Fan <peng.fan@....com>

Acked-by: Mike Rapoport <rppt@...ux.ibm.com>

> ---
>  arch/arm64/mm/init.c | 20 +-------------------
>  1 file changed, 1 insertion(+), 19 deletions(-)
> 
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 7205a9085b4d..2302b4093a63 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -285,24 +285,6 @@ int pfn_valid(unsigned long pfn)
>  }
>  EXPORT_SYMBOL(pfn_valid);
>  
> -#ifndef CONFIG_SPARSEMEM
> -static void __init arm64_memory_present(void)
> -{
> -}
> -#else
> -static void __init arm64_memory_present(void)
> -{
> -	struct memblock_region *reg;
> -
> -	for_each_memblock(memory, reg) {
> -		int nid = memblock_get_region_node(reg);
> -
> -		memory_present(nid, memblock_region_memory_base_pfn(reg),
> -				memblock_region_memory_end_pfn(reg));
> -	}
> -}
> -#endif
> -
>  static phys_addr_t memory_limit = PHYS_ADDR_MAX;
>  
>  /*
> @@ -489,7 +471,7 @@ void __init bootmem_init(void)
>  	 * Sparsemem tries to allocate bootmem in memory_present(), so must be
>  	 * done after the fixed reservations.
>  	 */
> -	arm64_memory_present();
> +	memblocks_present();
>  
>  	sparse_init();
>  	zone_sizes_init(min, max);
> -- 
> 2.14.1
> 

-- 
Sincerely yours,
Mike.