linux-kernel - Re: [PATCH] drm/vkms: WARN when hrtimer_forward

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190210123907.cbfcq6lgjooskpii@smtp.gmail.com>
Date:   Sun, 10 Feb 2019 10:39:07 -0200
From:   Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>
To:     Shayenne Moura <shayenneluzmoura@...il.com>
Cc:     Haneen Mohammed <hamohammed.sa@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/vkms: WARN when hrtimer_forward_now fails

On 02/06, Shayenne Moura wrote:
> Make the variable have the same type of function hrtimer_forward_now
> return.

Hi,

First of all, thanks for your patch.

Applied to the drm-misc-misc branch of drm-misc.git.

P.s.: I made a tiny change in the commit message.

Best Regards

> Add a warn to verify the hrtimer_forward_now return.
> 
> Signed-off-by: Shayenne Moura <shayenneluzmoura@...il.com>
> ---
>  drivers/gpu/drm/vkms/vkms_crtc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c
> index 5a095610726b..734a3e197df8 100644
> --- a/drivers/gpu/drm/vkms/vkms_crtc.c
> +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
> @@ -16,7 +16,7 @@ static enum hrtimer_restart vkms_vblank_simulate(struct hrtimer *timer)
>  						  vblank_hrtimer);
>  	struct drm_crtc *crtc = &output->crtc;
>  	struct vkms_crtc_state *state = to_vkms_crtc_state(crtc->state);
> -	int ret_overrun;
> +	u64 ret_overrun;
>  	bool ret;
>  
>  	spin_lock(&output->lock);
> @@ -43,6 +43,8 @@ static enum hrtimer_restart vkms_vblank_simulate(struct hrtimer *timer)
>  
>  	ret_overrun = hrtimer_forward_now(&output->vblank_hrtimer,
>  					  output->period_ns);
> +	WARN_ON(ret_overrun != 1);
> +
>  	spin_unlock(&output->lock);
>  
>  	return HRTIMER_RESTART;
> -- 
> 2.17.1
> 

-- 
Rodrigo Siqueira
https://siqueira.tech
Graduate Student
Department of Computer Science
University of São Paulo

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)