linux-kernel - Re: [RFC v1] tlv320aic32x4: delay i2c access by 1 ms after hardware reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190211150425.GE22391@sirena.org.uk>
Date:   Mon, 11 Feb 2019 15:04:25 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Peter Seiderer <ps.report@....net>
Cc:     linux-kernel@...r.kernel.org, Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, b-ak <anur.bhargav@...il.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        alsa-devel@...a-project.org
Subject: Re: [RFC v1] tlv320aic32x4: delay i2c access by 1 ms after hardware
 reset

On Sun, Feb 10, 2019 at 04:45:19PM +0100, Peter Seiderer wrote:

> @@ -972,6 +972,8 @@ static int aic32x4_component_probe(struct snd_soc_component *component)
>  		gpio_set_value(aic32x4->rstn_gpio, 1);
>  	}
>  
> +	mdelay(1);
> +

Perhaps only do this if we toggled the GPIO?  If the device wasn't in
reset then there's no need to wait.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)