linux-kernel - Re: [PATCH 17/22] ASoC: samsung: odroid: Add support for secondary CPU DAI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <c60fb7b9-8847-7e68-2ef4-4dbbfb48e71a@samsung.com>
Date:   Mon, 11 Feb 2019 16:19:11 +0100
From:   Sylwester Nawrocki <s.nawrocki@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     broonie@...nel.org, lgirdwood@...il.com, sbkim73@...sung.com,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Bartłomiej Żołnierkiewicz 
        <b.zolnierkie@...sung.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH 17/22] ASoC: samsung: odroid: Add support for secondary
 CPU DAI

On 2/11/19 14:57, Krzysztof Kozlowski wrote:
>> static struct snd_soc_dai_link odroid_card_dais[] = {
>> +       {
>> +               /* Primary FE <-> BE link */
>> +               .codec_name = "snd-soc-dummy",
>> +               .codec_dai_name = "snd-soc-dummy-dai",
>> +               .ops = &odroid_card_fe_ops,
>> +               .name = "Primary",
>> +               .stream_name = "Primary",
>> +               .platform_name = "3830000.i2s",

> Why exposing address as platform_name? I think it is not used so how
> about some friendlier name?
 
This entry is for selecting "PCM" (DMA) component for the link. 
For proper matching we need to use names of devices for which
the dmaengine based PCM component is registered (with a call to
samsung_asoc_dma_platform_register()).

We can't use platform_of_node because 2 PCM components ("3830000.i2s", 
"samsung-i2s-sec") are now associated with same DT node.


>> +       }, {
>> +               /* BE <-> CODECs link */
>> +       }, {
>> +               /* Secondary FE <-> BE link */

>> +               .platform_name = "samsung-i2s-sec",

>> +       }
>>  };


--
Thanks, 
Sylwester