linux-kernel - Re: [PATCH] Documentation/DMA-ISA-LPC: fix an incorrect reference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190211082324.40baa0cd@lwn.net>
Date:   Mon, 11 Feb 2019 08:23:24 -0700
From:   Jonathan Corbet <corbet@....net>
To:     Christoph Hellwig <hch@....de>
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation/DMA-ISA-LPC: fix an incorrect reference

On Mon, 11 Feb 2019 14:43:23 +0100
Christoph Hellwig <hch@....de> wrote:

> AFAIK we never had a isa_virt_to_phys, it always was
> isa_virt_to_bus.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> ---
>  Documentation/DMA-ISA-LPC.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/DMA-ISA-LPC.txt b/Documentation/DMA-ISA-LPC.txt
> index 8c2b8be6e45b..b1ec7b16c21f 100644
> --- a/Documentation/DMA-ISA-LPC.txt
> +++ b/Documentation/DMA-ISA-LPC.txt
> @@ -52,8 +52,8 @@ Address translation
>  -------------------
>  
>  To translate the virtual address to a bus address, use the normal DMA
> -API. Do _not_ use isa_virt_to_phys() even though it does the same
> -thing. The reason for this is that the function isa_virt_to_phys()
> +API. Do _not_ use isa_virt_to_bus() even though it does the same
> +thing. The reason for this is that the function isa_virt_to_bus()
>  will require a Kconfig dependency to ISA, not just ISA_DMA_API which
>  is really all you need. Remember that even though the DMA controller
>  has its origins in ISA it is used elsewhere.

Applied, thanks.

jon