linux-kernel - Re: [PATCH 1/2] parport: daisy: use new parport device model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190211083815.GB5207@kroah.com>
Date:   Mon, 11 Feb 2019 09:38:15 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] parport: daisy: use new parport device model

On Sat, Feb 09, 2019 at 08:59:06PM +0000, Sudip Mukherjee wrote:
> -	return bus_register(&parport_bus_type);
> +	int retval;
> +
> +	retval = bus_register(&parport_bus_type);
> +	if (retval)
> +		return retval;
> +#ifdef CONFIG_PARPORT_1284
> +	daisy_drv_init();
> +#endif

Shouldn't you hide these #ifdef lines in the .h file instead of putting
them in the .c file?

thanks,

greg k-h