linux-kernel - Re: [PATCH v5 5/5] i2c:ocores: checkpatch fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190211161942.ckuys4vyagbwaklq@ninjato>
Date:   Mon, 11 Feb 2019 17:19:43 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Peter Rosin <peda@...ntia.se>
Cc:     Federico Vaga <federico.vaga@...n.ch>,
        Peter Korsgaard <peter@...sgaard.com>,
        Andrew Lunn <andrew@...n.ch>,
        "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 5/5] i2c:ocores: checkpatch fixes


> > -	oc_setreg(i2c, OCI2C_CONTROL, ctrl & ~(OCI2C_CTRL_EN|OCI2C_CTRL_IEN));
> > +	ctrl = oc_getreg(i2c, OCI2C_CONTROL);
> 
> There's a pointless double oc_getreg(i2c, OCI2C_CONTROL).

In case you need to resend, please update $subject of all patches to
have a space after "i2c:"


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)