linux-kernel - Re: linux-next: Fixes tag needs some work in the driver-core tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190211171047.GN11489@garbanzo.do-not-panic.com>
Date:   Mon, 11 Feb 2019 09:10:47 -0800
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Greg KH <greg@...ah.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the driver-core tree

On Mon, Feb 11, 2019 at 08:44:02AM +0100, Greg KH wrote:
> On Mon, Feb 11, 2019 at 07:40:52AM +1100, Stephen Rothwell wrote:
> > Hi Greg,
> > 
> > In commit
> > 
> >   344c0152d878 ("selftests: firmware: fix verify_reqs() return value")
> > 
> > Fixes tag
> > 
> >   Fixes: a6a9be9270c87 ("selftests: firmware: return Kselftest Skip code for for skipped tests")
> > 
> > has these problem(s):
> > 
> >   - Subject does not match target commit subject
> 
> I don't understand, what is wrong with the fixes: tag here?
> 
> $ git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n" a6a9be9270c87
> a6a9be9270c8 ("selftests: firmware: return Kselftest Skip code for skipped tests")
> 
> How does that not match up?
> 
> Ah, an extra "for" in there.  Luis, you need to fix up your scripts, and
> not be forced to manually type in those lines :)

Will do.

  Luis