linux-kernel - Re: [PATCH v3 1/2] media: uapi: Add H264 low-level decoder API compound controls.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <209bafb880bd9410f875f5e6f16923e38ec76df4.camel@collabora.com>
Date:   Mon, 11 Feb 2019 14:12:25 -0300
From:   Ezequiel Garcia <ezequiel@...labora.com>
To:     nicolas.dufresne@...labora.com, tfiga@...omium.org,
        posciak@...omium.org, Maxime Ripard <maxime.ripard@...tlin.com>,
        hans.verkuil@...co.com, acourbot@...omium.org,
        sakari.ailus@...ux.intel.com,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        Chen-Yu Tsai <wens@...e.org>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-media@...r.kernel.org,
        jenskuske@...il.com, jernej.skrabec@...il.com, jonas@...boo.se,
        linux-sunxi@...glegroups.com,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH v3 1/2] media: uapi: Add H264 low-level decoder API
 compound controls.

On Mon, 2019-02-11 at 15:39 +0100, Maxime Ripard wrote:
> 
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index d6eed479c3a6..6fc955926bdb 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -645,6 +645,7 @@ struct v4l2_pix_format {
>  #define V4L2_PIX_FMT_H264     v4l2_fourcc('H', '2', '6', '4') /* H264 with start codes */
>  #define V4L2_PIX_FMT_H264_NO_SC v4l2_fourcc('A', 'V', 'C', '1') /* H264 without start codes */
>  #define V4L2_PIX_FMT_H264_MVC v4l2_fourcc('M', '2', '6', '4') /* H264 MVC */
> +#define V4L2_PIX_FMT_H264_SLICE v4l2_fourcc('S', '2', '6', '4') /* H264 parsed slices */

Nicolas and I have discussed the pixel format, and came up with
the following proposal.

Given this format represents H264 parsed slices, without any start code,
perhpaps we name it as:

V4L2_PIX_FMT_H264_SLICE_RAW

Then, we'd also add:

V4L2_PIX_FMT_H264_SLICE_ANNEX_B

To represent H264 parsed slices with annex B (3- or 4-byte) start code.
This one is what the Rockchip VPU driver would expose.

Ideas?