linux-kernel - Re: [PATCH] vmw_balloon: release lock on error in vmballoon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <A3173F98-AE61-48DF-8AA8-6757C3C086F7@vmware.com>
Date:   Mon, 11 Feb 2019 19:12:40 +0000
From:   Nadav Amit <namit@...are.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Julien Freche <jfreche@...are.com>,
        Xavier Deguillard <xdeguillard@...are.com>,
        Pv-drivers <Pv-drivers@...are.com>,
        Arnd Bergmann <arnd@...db.de>,
        LKML <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] vmw_balloon: release lock on error in vmballoon_reset()

> On Feb 11, 2019, at 10:45 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> 
> We added some locking to this function but forgot to drop the lock on
> these two error paths.  This bug would lead to an immediate deadlock.
> 
> Fixes: c7b3690fb152 ("vmw_balloon: stats rework")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Cc: stable@...r.kernel.org
Reviewed-by: Nadav Amit <namit@...are.com>

--

Yes, I screwed up. Thanks for catching it!

I’ll go to check why my error injection tests didn’t catch it.