linux-kernel - Re: [PATCH 4.20 081/352] f2fs: avoid build warn of fall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Feb 2019 07:18:58 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Jaegeuk Kim <jaegeuk@...nel.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.20 081/352] f2fs: avoid build warn of fall_through

Hi Greg,

On Mon, 11 Feb 2019 15:15:08 +0100 Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
>
> 4.20-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> [ Upstream commit f5d5510e7389fa264337fb524346bac9eb93adc8 ]
> 
> After merging the f2fs tree, today's linux-next build
>  (x86_64_allmodconfig) produced this warning:
> 
>  In file included from fs/f2fs/dir.c:11:
>  fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag':
>  fs/f2fs/f2fs.h:2388:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>     if (set)
>        ^
>  fs/f2fs/f2fs.h:2390:2: note: here
>    case FI_DATA_EXIST:
>    ^~~~
> 
>  Exposed by my use of -Wimplicit-fallthrough

Does the 4.20 stable tree use -Wimplicit-fallthrough?  I assume not
(since v4.20 doesn't), so this warning does not happen in that tree.
-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped