[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190211204710.GE24692@ziepe.ca>
Date: Mon, 11 Feb 2019 13:47:10 -0700
From: Jason Gunthorpe <jgg@...pe.ca>
To: ira.weiny@...el.com, linux-rdma@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-mm@...ck.org,
Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
Mike Marciniszyn <mike.marciniszyn@...el.com>,
Dennis Dalessandro <dennis.dalessandro@...el.com>,
Doug Ledford <dledford@...hat.com>,
Andrew Morton <akpm@...ux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH 0/3] Add gup fast + longterm and use it in HFI1
On Mon, Feb 11, 2019 at 12:34:17PM -0800, Davidlohr Bueso wrote:
> On Mon, 11 Feb 2019, ira.weiny@...el.com wrote:
> > Ira Weiny (3):
> > mm/gup: Change "write" parameter to flags
> > mm/gup: Introduce get_user_pages_fast_longterm()
> > IB/HFI1: Use new get_user_pages_fast_longterm()
>
> Out of curiosity, are you planning on having all rdma drivers
> use get_user_pages_fast_longterm()? Ie:
>
> hw/mthca/mthca_memfree.c: ret = get_user_pages_fast(uaddr & PAGE_MASK, 1, FOLL_WRITE, pages);
This one is certainly a mistake - this should be done with a umem.
Jason
Powered by blists - more mailing lists