lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Feb 2019 02:50:24 -0700 From: "Jan Beulich" <JBeulich@...e.com> To: "Gustavo A.R.Silva" <gustavo@...eddedor.com> Cc: "Paul Durrant" <paul.durrant@...rix.com>, "Wei Liu" <wei.liu2@...rix.com>, <davem@...emloft.net>, "xen-devel" <xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org> Subject: Re: [Xen-devel] [PATCH net-next] xen-netback: mark expected switch fall-through >>> On 08.02.19 at 20:58, <gustavo@...eddedor.com> wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enabling > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com> > --- > drivers/net/xen-netback/xenbus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/xen-netback/xenbus.c > b/drivers/net/xen-netback/xenbus.c > index 2625740bdc4a..330ddb64930f 100644 > --- a/drivers/net/xen-netback/xenbus.c > +++ b/drivers/net/xen-netback/xenbus.c > @@ -655,7 +655,7 @@ static void frontend_changed(struct xenbus_device *dev, > set_backend_state(be, XenbusStateClosed); > if (xenbus_dev_is_online(dev)) > break; > - /* fall through if not online */ > + /* fall through - if not online */ > case XenbusStateUnknown: Considering the fall-through was already annotated, I don't think title and description really justify the change. Is the compiler after a particular wording here? Jan
Powered by blists - more mailing lists