linux-kernel - Re: + sysctl-return-einval-if-val-violates-minmax.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190211211716.GA31039@avx2>
Date:   Tue, 12 Feb 2019 00:17:16 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     akpm@...ux-foundation.org
Cc:     linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk,
        mcgrof@...nel.org, longman@...hat.com, linux@...inikbrodowski.net,
        keescook@...omium.org, joe.lawrence@...hat.com,
        ebiederm@...ssion.com, christian@...uner.io
Subject: Re: + sysctl-return-einval-if-val-violates-minmax.patch added to -mm
 tree

On Mon, Feb 11, 2019 at 01:06:32PM -0800, akpm@...ux-foundation.org wrote:

> @@ -2848,8 +2848,10 @@ static int __do_proc_doulongvec_minmax(v

> -			if ((min && val < *min) || (max && val > *max))
> -				continue;
> +			if ((min && val < *min) || (max && val > *max)) {
> +				err = -EINVAL;

I was asked to return ERANGE in kstrto*().
If nothing, it gives better error message:

	$ ./a.out
	foo: Numerical result out of range