linux-kernel - Re: [PATCH v2] i2c: core-smbus: don't trace smbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFNjLiVMOii_mzs4Px38GHxFq6WnrDNhQ9YHMb+4yGZZ6SFpkQ@mail.gmail.com>
Date:   Mon, 11 Feb 2019 13:43:54 -0800
From:   John Sperbeck <jsperbeck@...gle.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Wolfram Sang <wsa@...-dreams.de>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v2] i2c: core-smbus: don't trace smbus_reply data on errors

On Mon, Feb 11, 2019 at 6:24 AM Steven Rostedt <rostedt@...dmis.org> wrote:
>
> On Sun, 10 Feb 2019 19:40:21 -0800
> John Sperbeck <jsperbeck@...gle.com> wrote:
>
> > If an smbus transfer fails, there's no guarantee that the output
> > buffer was written.  So, avoid trying to show the output buffer when
> > tracing after an error.  This was 'mostly harmless', but would trip
> > up kasan checking if left-over cruft in byte 0 is a large length,
> > causing us to read from unwritten memory.
>
> This looks fine to me, but I'm not sure how the i2c maintainers feel,
> but I always require that a new patch version starts a new thread, and
> not be part of a older thread release (causes these patches to be
> hidden from those that read patches in threading mode).

That sounds reasonable to me.  Unless I hear otherwise, I'll create a
v3 as a new thread.  Thanks.