linux-kernel - Re: [PATCH] libertas_tf: lower the debug level of command trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALLGbRLZGJGjJuYsno-y8=5UWZ9xjwvgTeM4hZRGNXS-Y+WF9Q@mail.gmail.com>
Date:   Mon, 11 Feb 2019 05:23:17 -0800
From:   Steve deRosier <derosier@...il.com>
To:     Lubomir Rintel <lkundrak@...sk>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] libertas_tf: lower the debug level of command trace

On Sun, Feb 10, 2019 at 11:47 AM Lubomir Rintel <lkundrak@...sk> wrote:
>
> Logging each and every command response is way too much for INFO level.
> Silence this, unless CONFIG_LIBERTAS_THINFIRM_DEBUG has been enabled.
>
> Signed-off-by: Lubomir Rintel <lkundrak@...sk>
> ---
>  drivers/net/wireless/marvell/libertas_tf/cmd.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/libertas_tf/cmd.c b/drivers/net/wireless/marvell/libertas_tf/cmd.c
> index 909ac3685010..64b147dd2432 100644
> --- a/drivers/net/wireless/marvell/libertas_tf/cmd.c
> +++ b/drivers/net/wireless/marvell/libertas_tf/cmd.c
> @@ -737,10 +737,9 @@ int lbtf_process_rx_command(struct lbtf_private *priv)
>         respcmd = le16_to_cpu(resp->command);
>         result = le16_to_cpu(resp->result);
>
> -       if (net_ratelimit())
> -               pr_info("libertastf: cmd response 0x%04x, seq %d, size %d\n",
> -                       respcmd, le16_to_cpu(resp->seqnum),
> -                       le16_to_cpu(resp->size));
> +       lbtf_deb_cmd("libertastf: cmd response 0x%04x, seq %d, size %d\n",
> +                    respcmd, le16_to_cpu(resp->seqnum),
> +                    le16_to_cpu(resp->size));
>
>         if (resp->seqnum != priv->cur_cmd->cmdbuf->seqnum) {
>                 spin_unlock_irqrestore(&priv->driver_lock, flags);
> --
> 2.20.1
>

Reviewed-by: Steve deRosier <derosier@...-sierra.com>