linux-kernel - Re: [PATCH] libertas_tf: fix signal reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 11 Feb 2019 05:39:55 -0800
From:   Steve deRosier <derosier@...il.com>
To:     Lubomir Rintel <lkundrak@...sk>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] libertas_tf: fix signal reporting

On Sun, Feb 10, 2019 at 11:48 AM Lubomir Rintel <lkundrak@...sk> wrote:
>
> Instead of exposing the signal-to-noise ration, calculate the actual signal
> level taking the noise floor into account.
>
> Also, flip the SIGNAL_DBM bit on, so that mac80211 exposes the signal
> level along with the station info in scan results. This fills
> NetworkManager's "nmcli d wifi output" output with colors, bars and joy.
>
> Signed-off-by: Lubomir Rintel <lkundrak@...sk>
> ---
>  drivers/net/wireless/marvell/libertas_tf/main.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/libertas_tf/main.c b/drivers/net/wireless/marvell/libertas_tf/main.c
> index c71ad87cdc44..f93b400db949 100644
> --- a/drivers/net/wireless/marvell/libertas_tf/main.c
> +++ b/drivers/net/wireless/marvell/libertas_tf/main.c
> @@ -562,7 +562,7 @@ int lbtf_rx(struct lbtf_private *priv, struct sk_buff *skb)
>                 stats.flag |= RX_FLAG_FAILED_FCS_CRC;
>         stats.freq = priv->cur_freq;
>         stats.band = NL80211_BAND_2GHZ;
> -       stats.signal = prxpd->snr;
> +       stats.signal = prxpd->snr - prxpd->nf;
>         priv->noise = prxpd->nf;
>         /* Marvell rate index has a hole at value 4 */
>         if (prxpd->rx_rate > 4)
> @@ -626,6 +626,7 @@ struct lbtf_private *lbtf_add_card(void *card, struct device *dmdev)
>
>         hw->queues = 1;
>         ieee80211_hw_set(hw, HOST_BROADCAST_PS_BUFFERING);
> +       ieee80211_hw_set(hw, SIGNAL_DBM);
>         hw->extra_tx_headroom = sizeof(struct txpd);
>         memcpy(priv->channels, lbtf_channels, sizeof(lbtf_channels));
>         memcpy(priv->rates, lbtf_rates, sizeof(lbtf_rates));
> --
> 2.20.1
>

Reviewed-by: Steve deRosier <derosier@...-sierra.com>