linux-kernel - Re: [PATCH] isdn: i4l: isdn_tty: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190212.102949.565787841270910392.davem@davemloft.net>
Date:   Tue, 12 Feb 2019 10:29:49 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     gustavo@...eddedor.com
Cc:     isdn@...ux-pingi.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, keescook@...omium.org
Subject: Re: [PATCH] isdn: i4l: isdn_tty: Mark expected switch fall-through

From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Date: Mon, 11 Feb 2019 16:38:21 -0600

> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> 
> This patch fixes the following warnings:
> 
> drivers/isdn/i4l/isdn_tty.c: In function ‘isdn_tty_edit_at’:
> drivers/isdn/i4l/isdn_tty.c:3644:18: warning: this statement may fall through [-Wimplicit-fallthrough=]
>        m->mdmcmdl = 0;
>        ~~~~~~~~~~~^~~
> drivers/isdn/i4l/isdn_tty.c:3646:5: note: here
>      case 0:
>      ^~~~
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
> 
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Applied.