linux-kernel - Re: [PATCH v2] net/packet: fix 4gb buffer limit due to overflow check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190212.103821.1113180544052186059.davem@davemloft.net>
Date:   Tue, 12 Feb 2019 10:38:21 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     kal.conley@...tris.com
Cc:     willemb@...gle.com, edumazet@...gle.com,
        alexander.h.duyck@...el.com, jeffrey.t.kirsher@...el.com,
        ktkhai@...tuozzo.com, vincent.whitchurch@...s.com,
        lirongqing@...du.com, magnus.karlsson@...el.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net/packet: fix 4gb buffer limit due to overflow
 check

From: Kal Conley <kal.conley@...tris.com>
Date: Sun, 10 Feb 2019 09:57:11 +0100

> When calculating rb->frames_per_block * req->tp_block_nr the result
> can overflow. Check it for overflow without limiting the total buffer
> size to UINT_MAX.
> 
> This change fixes support for packet ring buffers >= UINT_MAX.
> 
> Fixes: 8f8d28e4d6d8 ("net/packet: fix overflow in check for tp_frame_nr")
> Signed-off-by: Kal Conley <kal.conley@...tris.com>
> ---
> Changes in v2:
> - Add Signed-off-by and Fixes tag

Applied and queued up for -stable, thanks.