linux-kernel - Re: [PATCH] lib/string: add memrchr function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Feb 2019 20:15:35 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     xiang xiao <xiaoxiang781216@...il.com>
Cc:     alexander.shishkin@...ux.intel.com,
        andriy.shevchenko@...ux.intel.com, linux-kernel@...r.kernel.org,
        Xiang Xiao <xiaoxiang@...omi.com>
Subject: Re: [PATCH] lib/string: add memrchr function

On Wed, Feb 13, 2019 at 03:09:19AM +0800, xiang xiao wrote:
> On Wed, Feb 13, 2019 at 2:34 AM Greg KH <gregkh@...uxfoundation.org> wrote:
> >
> > On Wed, Feb 13, 2019 at 02:06:49AM +0800, Xiang Xiao wrote:
> > > Here is the detailed description for memrchr:
> > > https://linux.die.net/man/3/memrchr
> >
> > Please put it in the changelog, as web pages move and go away :(
> 
> Sure.
> 
> >
> > >
> > > Signed-off-by: Xiang Xiao <xiaoxiang@...omi.com>
> > > ---
> > >  include/linux/string.h |  1 +
> > >  lib/string.c           | 21 +++++++++++++++++++++
> > >  2 files changed, 22 insertions(+)
> > >
> > > diff --git a/include/linux/string.h b/include/linux/string.h
> > > index 7927b87..f380f4b 100644
> > > --- a/include/linux/string.h
> > > +++ b/include/linux/string.h
> > > @@ -167,6 +167,7 @@ static inline void memcpy_flushcache(void *dst, const void *src, size_t cnt)
> > >       memcpy(dst, src, cnt);
> > >  }
> > >  #endif
> > > +void *memrchr(const void *s, int c, size_t n);
> >
> > Who is going to use this?
> 
> This patch will use memrchr:
> https://github.com/thesofproject/linux/pull/177/commits/a0b7009fede5552dc98733f2996a8140bff62455
> I am preparing to upstream it.

Great, make it part of the patch series for your driver, no need to
submit it separately.

thanks,

greg k-h