linux-kernel - Re: [PATCH] rtc: rv3028: new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190212232132.GG10129@piout.net>
Date:   Wed, 13 Feb 2019 00:21:32 +0100
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Marek Vasut <marex@...x.de>
Cc:     linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: rv3028: new driver

On 30/01/2019 17:13:27+0100, Marek Vasut wrote:
> On 1/30/19 4:00 PM, Alexandre Belloni wrote:
> > Add a driver for the MicroCrystal RV-3028.
> 
> Some additional information in the commit message won't hurt.
> 
> > Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> > ---
> >  Documentation/devicetree/bindings/rtc/rtc.txt |   1 +
> >  drivers/rtc/Kconfig                           |   9 +
> >  drivers/rtc/Makefile                          |   1 +
> >  drivers/rtc/rtc-rv3028.c                      | 732 ++++++++++++++++++
> >  4 files changed, 743 insertions(+)
> >  create mode 100644 drivers/rtc/rtc-rv3028.c
> > 
> > diff --git a/Documentation/devicetree/bindings/rtc/rtc.txt b/Documentation/devicetree/bindings/rtc/rtc.txt
> > index d86e2850fe1c..3e6a215e7304 100644
> > --- a/Documentation/devicetree/bindings/rtc/rtc.txt
> > +++ b/Documentation/devicetree/bindings/rtc/rtc.txt
> > @@ -52,6 +52,7 @@ emmicro,em3027		EM Microelectronic EM3027 Real-time Clock
> >  isil,isl1208		Intersil ISL1208 Low Power RTC with Battery Backed SRAM
> >  isil,isl1218		Intersil ISL1218 Low Power RTC with Battery Backed SRAM
> >  isil,isl12022		Intersil ISL12022 Real-time Clock
> > +microcrystal,rv3028	Real Time Clock Module with I2C-Bus
> 
> Shouldn't this be a separate patch ?
> 

Not really as this doesn't introduce any new binding and simply
documents a compatible string. Rob is loaded enough to not review that
kind of changes.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com