linux-kernel - Re: [PATCH v3 1/4] mfd: max77620: Add backup battery charger support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190212080611.GM20638@dell>
Date:   Tue, 12 Feb 2019 08:06:11 +0000
From:   Lee Jones <lee.jones@...aro.org>
To:     Mark Zhang <markz@...dia.com>
Cc:     robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org,
        Laxman Dewangan <ldewangan@...dia.com>,
        Venkat Reddy Talla <vreddytalla@...dia.com>
Subject: Re: [PATCH v3 1/4] mfd: max77620: Add backup battery charger support

On Tue, 12 Feb 2019, Mark Zhang wrote:

> Add PMIC configurations for backup battery charger, which
> is a constant voltage and constant current style charger
> with a series output resistance.
> 
> The max77620 register CNFGBBC(addr: 0x04) defines the
> parameters of backup battery charger. This patch adds
> support for it.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@...dia.com>
> Signed-off-by: Venkat Reddy Talla <vreddytalla@...dia.com>
> Signed-off-by: Mark Zhang <markz@...dia.com>
> ---
>  drivers/mfd/max77620.c | 80 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 80 insertions(+)

My previous review comments still apply.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog