lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Feb 2019 13:43:33 +0530 From: Kishon Vijay Abraham I <kishon@...com> To: Adrian Hunter <adrian.hunter@...el.com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Ulf Hansson <ulf.hansson@...aro.org>, Thierry Reding <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com> CC: <linux-mmc@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-tegra@...r.kernel.org>, Faiz Abbas <faiz_abbas@...com>, Thierry Reding <treding@...dia.com> Subject: Re: [PATCH v2 2/3] mmc: sdhci-omap: drop ->get_ro() implementation On 12/02/19 1:41 PM, Adrian Hunter wrote: > On 11/02/19 3:23 PM, Thomas Petazzoni wrote: >> The SDHCI core is now properly checking for the state of a WP GPIO, >> so there is no longer any need for the sdhci-omap code to implement >> ->get_ro() using mmc_gpio_get_ro(). >> >> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@...tlin.com> >> Reviewed-by: Thierry Reding <treding@...dia.com> > > Acked-by: Adrian Hunter <adrian.hunter@...el.com> Acked-by: Kishon Vijay Abraham I <kishon@...com> > >> --- >> Changes since v1: >> - Added Reviewed-by from Thierry Reding >> - Fix typo in commit log s/know/now/ noticed by Thierry Reding >> >> Note: this patch has only been compiled tested, as I don't have the >> hardware to test it. >> --- >> drivers/mmc/host/sdhci-omap.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c >> index d264391616f9..c2a28930086f 100644 >> --- a/drivers/mmc/host/sdhci-omap.c >> +++ b/drivers/mmc/host/sdhci-omap.c >> @@ -987,7 +987,6 @@ static int sdhci_omap_probe(struct platform_device *pdev) >> goto err_put_sync; >> } >> >> - host->mmc_host_ops.get_ro = mmc_gpio_get_ro; >> host->mmc_host_ops.start_signal_voltage_switch = >> sdhci_omap_start_signal_voltage_switch; >> host->mmc_host_ops.set_ios = sdhci_omap_set_ios; >> >
Powered by blists - more mailing lists