linux-kernel - Re: [RESEND PATCH v2 02/33] ARM: davinci: aintc: use irq domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Feb 2019 13:56:38 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     Bartosz Golaszewski <brgl@...ev.pl>,
        Kevin Hilman <khilman@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        David Lechner <david@...hnology.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [RESEND PATCH v2 02/33] ARM: davinci: aintc: use irq domain

On 11/02/19 5:55 PM, Bartosz Golaszewski wrote:
> @@ -74,6 +75,7 @@ void __init davinci_irq_init(void)
>  {
>  	unsigned i, j;
>  	const u8 *davinci_def_priorities = davinci_soc_info.intc_irq_prios;
> +	int rv, irq_base;
>  
>  	davinci_intc_type = DAVINCI_INTC_TYPE_AINTC;
>  	davinci_intc_base = ioremap(davinci_soc_info.intc_base, SZ_4K);
> @@ -110,8 +112,25 @@ void __init davinci_irq_init(void)
>  		davinci_irq_writel(pri, i);
>  	}
>  
> +	irq_base = irq_alloc_descs(-1, 0, davinci_soc_info.intc_irq_num, 0);
> +	if (WARN_ON(irq_base < 0))
> +		return;
> +
> +	davinci_irq_domain = irq_domain_add_legacy(NULL,
> +					davinci_soc_info.intc_irq_num,
> +					irq_base, 0, &irq_domain_simple_ops,
> +					NULL);
> +	if (WARN_ON(!davinci_irq_domain))
> +		return;
> +
> +	rv = irq_alloc_domain_generic_chips(davinci_irq_domain, 32, 1,
> +					    "AINTC", handle_edge_irq,
> +					    IRQ_NOREQUEST | IRQ_NOPROBE, 0, 0);
> +	if (WARN_ON(rv))
> +		return;

Like you have done in other places, use "ret" instead of "rv" for
consistency.

Thanks,
Sekhar