linux-kernel - Re: [PATCH 5/5] riscv: use for_each_of_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6518a7ff-0586-be7a-4a43-6c9a35194a05@wdc.com>
Date:   Tue, 12 Feb 2019 00:47:09 -0800
From:   Atish Patra <atish.patra@....com>
To:     Johan Hovold <johan@...nel.org>,
        Christoph Hellwig <hch@...radead.org>
Cc:     Palmer Dabbelt <palmer@...ive.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Andreas Schwab <schwab@...e.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Anup Patel <anup@...infault.org>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH 5/5] riscv: use for_each_of_cpu_node iterator

On 2/12/19 12:26 AM, Johan Hovold wrote:
> On Mon, Feb 11, 2019 at 11:13:39PM -0800, Christoph Hellwig wrote:
>> On Fri, Jan 18, 2019 at 03:03:08PM +0100, Johan Hovold wrote:
>>> Use the new for_each_of_cpu_node() helper to iterate over cpu nodes
>>> instead of open coding. Note that this will allow matching also on the
>>> node name instead of the (for FDT) deprecated device_type property.
>>>
>>> Signed-off-by: Johan Hovold <johan@...nel.org>
>>
>> I think this is going to conflict with the ELF caps changes from
>> Atish.  Maybe the riscv_fill_hwcap hunk should be included in his
>> patch?
> 
> Since that patch had some issues (e.g. the node reference underflow) it
> may be better to rebase it on top of this series. The changes are
> otherwise distinct after all.
> 

I have fixed the node reference underflow issue and made some more 
changes based on comments.

Some other patches(1,3,4,5) in this series may conflict with my series 
as well. I can rebase my series on top of yours and send it as one 
series if that's okay with you and Palmer.

Regards,
Atish
>> Otherwise looks good:
>>
>> Reviewed-by: Christoph Hellwig <hch@....de>
> 
> Thanks for reviewing!
> 
> Johan
>