linux-kernel - Re: [PATCH] mei: expand minor range when registering chrdev region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190212092902.GD27450@kroah.com>
Date:   Tue, 12 Feb 2019 10:29:02 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Chengguang Xu <cgxu519@....com>
Cc:     tomas.winkler@...el.com, arnd@...db.de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mei: expand minor range when registering chrdev region

On Tue, Feb 12, 2019 at 02:02:52PM +0800, Chengguang Xu wrote:
> Actually, total amount of available minor number
> for a single major is MINORMARK + 1. So expand
> minor range when registering chrdev region.
> 
> Signed-off-by: Chengguang Xu <cgxu519@....com>
> ---
>  drivers/misc/mei/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
> index 87281b3695e6..3df54f1e1a8b 100644
> --- a/drivers/misc/mei/main.c
> +++ b/drivers/misc/mei/main.c
> @@ -869,7 +869,7 @@ static const struct file_operations mei_fops = {
>  
>  static struct class *mei_class;
>  static dev_t mei_devt;
> -#define MEI_MAX_DEVS  MINORMASK
> +#define MEI_MAX_DEVS  (MINORMASK + 1)

Why is this needed?  Have you really run out of that many minor nodes
for this driver?

thanks,

greg k-h