linux-kernel - Re: [RESEND PATCH v2 29/33] ARM: davinci: cp-intc: use readl/writel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MfmKTJcoLzRb5Auz2mYD8pka-=p46MSxjrnXwDYKDR3=Q@mail.gmail.com>
Date:   Tue, 12 Feb 2019 10:32:56 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Marc Zyngier <marc.zyngier@....com>
Cc:     Sekhar Nori <nsekhar@...com>, Kevin Hilman <khilman@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        David Lechner <david@...hnology.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [RESEND PATCH v2 29/33] ARM: davinci: cp-intc: use readl/writel_relaxed()

pon., 11 lut 2019 o 14:08 Marc Zyngier <marc.zyngier@....com> napisał(a):
>
> On 11/02/2019 12:26, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> >
> > Raplace all calls to __raw_readl() & __raw_writel() with readl_relaxed()
> > and writel_relaxed() respectively. It's safe to do as there's no
> > endianness conversion being done in the code.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> > ---
> >  arch/arm/mach-davinci/cp_intc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-davinci/cp_intc.c b/arch/arm/mach-davinci/cp_intc.c
> > index c1efb9390655..4bbf0eba1920 100644
> > --- a/arch/arm/mach-davinci/cp_intc.c
> > +++ b/arch/arm/mach-davinci/cp_intc.c
> > @@ -45,13 +45,13 @@ static struct irq_domain *davinci_cp_intc_irq_domain;
> >
> >  static inline unsigned int davinci_cp_intc_read(unsigned int offset)
> >  {
> > -     return __raw_readl(davinci_cp_intc_base + offset);
> > +     return readl_relaxed(davinci_cp_intc_base + offset);
> >  }
> >
> >  static inline void davinci_cp_intc_write(unsigned long value,
> >                                        unsigned int offset)
> >  {
> > -     __raw_writel(value, davinci_cp_intc_base + offset);
> > +     writel_relaxed(value, davinci_cp_intc_base + offset);
> >  }
> >
> >  static void davinci_cp_intc_ack_irq(struct irq_data *d)
> >
>
> Same thing. Please merge this patch with the one that introduced the
> __raw_writel() stuff.
>

In this case, none of my patches introduced it - it used to be like
that from the beginning, so a separate patch is justified.

Bart