[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJZ5v0hez63un9g4h0U+YOZV1o7S+FT8NritiX6dxEcD1-fTSQ@mail.gmail.com>
Date: Tue, 12 Feb 2019 11:54:29 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Viresh Kumar <viresh.kumar@...aro.org>
Cc: Rafael Wysocki <rjw@...ysocki.net>,
Linux PM <linux-pm@...r.kernel.org>,
Vincent Guittot <vincent.guittot@...aro.org>,
Sudeep Holla <sudeep.holla@....com>,
Marek Szyprowski <m.szyprowski@...sung.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 1/2] cpufreq: Allow light-weight tear down and bring up
of CPUs
On Tue, Feb 12, 2019 at 11:47 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>
[cut]
> @@ -2488,7 +2505,8 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data)
> driver_data->target) ||
> (driver_data->setpolicy && (driver_data->target_index ||
> driver_data->target)) ||
> - (!!driver_data->get_intermediate != !!driver_data->target_intermediate))
> + (!!driver_data->get_intermediate != !!driver_data->target_intermediate) ||
> + (!driver_data->online ^ !driver_data->offline))
Why do you need the ^ here? != should be sufficient:
!driver_data->online != !driver_data->offline
?
> return -EINVAL;
>
> pr_debug("trying to register driver %s\n", driver_data->name);
Powered by blists - more mailing lists