linux-kernel - Re: [PATCH V3 1/2] cpufreq: Allow light-weight tear down and bring up of CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 12 Feb 2019 11:54:29 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Rafael Wysocki <rjw@...ysocki.net>,
        Linux PM <linux-pm@...r.kernel.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Sudeep Holla <sudeep.holla@....com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 1/2] cpufreq: Allow light-weight tear down and bring up
 of CPUs

On Tue, Feb 12, 2019 at 11:47 AM Viresh Kumar <viresh.kumar@...aro.org> wrote:
>

[cut]

> @@ -2488,7 +2505,8 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data)
>                     driver_data->target) ||
>              (driver_data->setpolicy && (driver_data->target_index ||
>                     driver_data->target)) ||
> -            (!!driver_data->get_intermediate != !!driver_data->target_intermediate))
> +            (!!driver_data->get_intermediate != !!driver_data->target_intermediate) ||
> +            (!driver_data->online ^ !driver_data->offline))

Why do you need the ^ here?  != should be sufficient:

!driver_data->online != !driver_data->offline

?

>                 return -EINVAL;
>
>         pr_debug("trying to register driver %s\n", driver_data->name);