lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Feb 2019 03:10:08 -0800 From: Atish Patra <atish.patra@....com> To: linux-riscv@...ts.infradead.org Cc: Atish Patra <atish.patra@....com>, Alan Kao <alankao@...estech.com>, Albert Ou <aou@...s.berkeley.edu>, Andreas Schwab <schwab@...e.de>, Anup Patel <anup@...infault.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, Dmitriy Cherkasov <dmitriy@...-tech.org>, Jason Cooper <jason@...edaemon.net>, Johan Hovold <johan@...nel.org>, linux-kernel@...r.kernel.org, Marc Zyngier <marc.zyngier@....com>, Palmer Dabbelt <palmer@...ive.com>, Paul Walmsley <paul.walmsley@...ive.com>, Rob Herring <robh@...nel.org>, Thomas Gleixner <tglx@...utronix.de> Subject: [v4 PATCH 4/8] RISC-V: Allow hartid-to-cpuid function to fail. It is perfectly okay to call riscv_hartid_to_cpuid for a hartid that is not mapped with an CPU id. It can happen if the calling functions retrieves the hartid from DT. However, that hartid was never brought online by the firmware or kernel for any reasons. No need to BUG() in the above case. A negative error return is sufficient and the calling function should check for the return value always. Signed-off-by: Atish Patra <atish.patra@....com> Reviewed-by: Anup Patel <anup@...infault.org> Reviewed-by: Christoph Hellwig <hch@....de> --- arch/riscv/kernel/smp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c index b69883c6..ca99f0fb 100644 --- a/arch/riscv/kernel/smp.c +++ b/arch/riscv/kernel/smp.c @@ -60,7 +60,6 @@ int riscv_hartid_to_cpuid(int hartid) return i; pr_err("Couldn't find cpu id for hartid [%d]\n", hartid); - BUG(); return i; } -- 2.7.4
Powered by blists - more mailing lists